Capture UC dependencies for vector search indexes - #6655
Open
janniklasrose wants to merge 2 commits into
Open
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 043f816
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extend the
CaptureUCDependenciesmutator to handle vector search indexes. A vector search index'snameis a three-partcatalog.schema.indexUC identifier. When the catalog or schema is also defined in the same bundle, the mutator now rewrites those segments to${resources.catalogs.<key>.name}/${resources.schemas.<key>.name}references, so the deploy engine captures the deploy-time dependency and creates the catalog/schema before the index.This follows the existing compound-name handling for quality monitors (
OutputSchemaName), just with three segments instead of two.Why
Without this, a bundle that defines a schema and a vector search index living in that schema has no captured ordering dependency, so a deploy can attempt to create the index before its schema exists.
Tests
TestCaptureUCDependenciesand addedTestCaptureUCDependenciesVectorSearchIndexEdgeCases(match / catalog-only / no-match / empty / two-part / nil), plus the nil-resources panic-safety case.bundle/resource_deps/implicit_deps_vector_search_indexmirrorsimplicit_deps_quality_monitor; all EnvMatrix variants (terraform/direct × DMS) produce identical output.This pull request and its description were written by Isaac.